celamantia
Bug on news page
June 19, 2002 at 04:04AM View BBCode
A promotion that was made as part of a trade had its link created incorrectly.
9/17/1950 The Chicago smp have promoted Bill Gregg to the major league team.
The link for Bill Gregg was created as:
http://www.simdynasty.com/4493
instead of:
http://www.simdynasty.com/player.jsp?id=4493
tysonlowery
June 19, 2002 at 01:22PM View BBCode
I fixed this one. Anyone else notice this on their pages? For some reason it was wrong in the database, but the rest of the entries were fine.
I'll have to look at the trade promotion part of the code, the bug is probably in there.
tysonlowery
June 25, 2002 at 02:21PM View BBCode
Well, I couldn't reproduce this error. I think it must of been a hanging page or something, not sure. Let me know if anyone sees it again.
celamantia
June 26, 2002 at 01:46PM View BBCode
It happened again. The Goats offered me this trade:
Trade:
Abie Mura, P
Acquire:
Steve Keatley, 2B
Clyde Krausse, P
Skeeter Barnes, 1B
Promote:
Bud Barbee
Wilbur Weston
When the trade completed, the News page showed the Goat's promotions of Barbee and Weston, but their URLs are screwed up again just like the original message.
Looks like it's hapenning in any trade with promotions/demotions as part of the trade.
Also, the "A trade has been completed" news item appears twice in the news, once at the beginning of the transaction and once at the end.
Finally, to accept the trade, I had to make a number of promotions, demotions, and waivers. All of these had their URLs created correctly, so it's just the promotes/demotes stored in the trade by the proposing side that are having problems.
tysonlowery
June 26, 2002 at 09:17PM View BBCode
Thanks for the help in tracking it down. I have the problem fixed for future trades like this so that the links show up correctly. I found where the bug was.
The trade shows up twice because it was actually accepted twice (must of double-clicked or something). It doesn't hurt anything, and I haven't seen it before, so let's just keep an eye out for it. It might just be a freak thing.
celamantia
June 27, 2002 at 03:27AM View BBCode
What happened was I accepted it, but I got the promotes and waives wrong, so it errored out. I hit the Back button and tried to fix it, and got the waives and promotes wrong again. Finally, I clicked Return to trade desk, accepted the trade, then finally got the waives and promotes right.
To fix this, perhaps the trade process and the waive/promote process should be separated. Just make the trade give you too many players, like the Amateur Draft; put the new players in the majors until its full, then dump the rest into the minors. Then, when noting that the trade is complete, remind the player that he now has 17 minor leaguers and must waive two, and provide a link to "Waive without a claim"... but at this point, the trade is done....
Pages: 1